feat: Better support for subaccounts#112
Merged
ggreif merged 3 commits intodfinity:masterfrom May 3, 2025
Merged
Conversation
ggreif
approved these changes
May 1, 2025
Contributor
ggreif
left a comment
ggreif
left a comment
There was a problem hiding this comment.
LGTM. Approving as low-risk.
Member
Author
Thanks for the review! Can you also help merge this? I don't see merge button at all from my side. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the following built-in function support:
account(principal, blob)converts principal and subaccount (blob) to account id (blob), used by the ICP ledger.subaccount(principal)converts principal to subaccount (blob), which is what the CMC canister expects.